Skip to content

docs: tweaks #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2018
Merged

docs: tweaks #642

merged 2 commits into from
May 23, 2018

Conversation

38elements
Copy link
Contributor

This remove unnecessary lines and makes it to easy to understand.

@@ -197,8 +197,6 @@ Pass properties for components to use in injection. See [provide/inject](https:/
- type: `boolean`
- default: `true`

Sets all watchers to run synchronously.
Copy link
Contributor Author

@38elements 38elements May 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was removed at #487.


`Boolean`: True if `attachedToDocument` was passed to `mount` or `shallowMount`
`Boolean`: True if `attachedToDocument` in mounting options was true 
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using mounting options is better.

Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@eddyerburgh eddyerburgh merged commit 60f3bf4 into vuejs:dev May 23, 2018
@38elements 38elements deleted the patch-1 branch May 24, 2018 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants