Hotfix/observe(Array) (trouble if use extends Array)

[cybermerlin]

same PR #9135

[posva]

What is this? What bug are you trying to fix? Can you provide a repro of the bug?
Also keep in mind all tests must pass and new tests must be added

[cybermerlin]

something like this:

class Some extends Array {
  add(v) { this.push(v) }
}

@Component
class CompoSuper extends Vue {
  @Prop(Array) items
  created(){ this.items.add(232) }  // << exception: method .add() is undefined
}

[cybermerlin]

test trouble with:

Unarchiving cache...
tar: root/project/vue/node_modules: Cannot mkdir: Permission denied```

O.o

[Justineo]

If it's a bug, do you mind providing a runnable reproduction first? We are not sure what problem you are going to solve.

[cybermerlin]

@Justineo look pls in #9136 (comment)

[cybermerlin]

#6920
#8963
#5893

[posva]

I feel like you have rushed this pr. If it's implementing that feature it would require proper testing of the actual feature request. Opening a pr with just Hotfix as a title is so
Confusing for us maintainers...

[cybermerlin]

@posva u r right.
n look PR #9135

[posva]

Okay, closing this, it's not against the right branch anyway