Skip to content

feat(auth): useIsCurrentUserLoaded() composable #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 14, 2023

Conversation

Soviut
Copy link
Contributor

@Soviut Soviut commented Feb 13, 2023

Closes #1306

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Soviut and others added 5 commits February 13, 2023 12:40
Co-authored-by: Eduardo San Martin Morote <[email protected]>
Co-authored-by: Eduardo San Martin Morote <[email protected]>
Co-authored-by: Eduardo San Martin Morote <[email protected]>
@Soviut
Copy link
Contributor Author

Soviut commented Feb 13, 2023

@posva I also added docs. Let me know if those are okay.

@codecov-commenter
Copy link

Codecov Report

Merging #1307 (0db548f) into main (9a961d4) will decrease coverage by 0.12%.
The diff coverage is 66.66%.

❗ Current head 0db548f differs from pull request most recent head 222ac37. Consider uploading reports for the commit 222ac37 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1307      +/-   ##
==========================================
- Coverage   90.05%   89.94%   -0.12%     
==========================================
  Files          21       21              
  Lines        3218     3232      +14     
  Branches      317      317              
==========================================
+ Hits         2898     2907       +9     
- Misses        320      325       +5     
Impacted Files Coverage Δ
src/storage/index.ts 83.65% <0.00%> (-0.54%) ⬇️
src/auth/user.ts 49.19% <75.00%> (+1.47%) ⬆️
src/auth/index.ts 78.84% <100.00%> (+0.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@posva posva changed the title feat(auth): added isUserLoaded composable feat(auth): useIsCurrentUserLoaded() composable Feb 14, 2023
@posva posva merged commit f640929 into vuejs:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose a userLoaded state from useCurrentUser to avoid "flash of logged out nav"
3 participants