Skip to content

feat: Sidebar toggle. #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

feat: Sidebar toggle. #761

wants to merge 3 commits into from

Conversation

MacZel
Copy link

@MacZel MacZel commented Aug 23, 2018

Summary

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

Other information:
This change enables to toggle sidebar when in desktop mode. It also styles default scrollbars in chrome and safari.
Default label is 'Hide/Show sidebar'. To change it modify config.js to:

sidebar: {
    toggle: {
        hideText: 'Ukryj menu',
        showText: 'Pokaż menu'
    },
}

Preview

@MacZel MacZel changed the title feat: Sidebar toggle. Initial commit. (#640) feat: Sidebar toggle. (#640) Aug 23, 2018
@MacZel MacZel changed the title feat: Sidebar toggle. (#640) feat: Sidebar toggle. Aug 23, 2018
@ulivz ulivz force-pushed the master branch 2 times, most recently from bd69d41 to 903138e Compare October 3, 2018 22:21
@ulivz ulivz force-pushed the master branch 2 times, most recently from 3f79224 to fb05066 Compare October 23, 2018 15:09
@ulivz ulivz force-pushed the master branch 3 times, most recently from 6c3127f to 71574f2 Compare December 18, 2018 18:27
@ulivz
Copy link
Member

ulivz commented Mar 13, 2019

Sorry but we don't plan to add this feature in default theme. maybe you can create a "derived theme" for it.

ref: https://v1.vuepress.vuejs.org/theme/inheritance.html

@ulivz ulivz closed this Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants