Fix export default in index.d.ts #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks in Typescript 2.6 with the error "The expression of an export assignment must be an identifier or qualified name in an ambient context." This commit also adds a small test that uses the default export, since no test existed previously.
ktsn
reviewed
Oct 18, 2017
types/index.d.ts
Outdated
| Store, | ||
| install | ||
| }; | ||
| export const _default: { |
There was a problem hiding this comment.
Oops! My mistake. I'll remove it.
ktsn
approved these changes
Oct 18, 2017
|
Thanks! |
|
Hi @ktsn do you have an idea of when this will make it into a release? I just ran into this while upgrading to TS 2.6 and I'm not sure if there's any resolution except for pinning to TS 2.5 until this fix is available. |
|
Please publish this change. |
|
v3.0.1 has been published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default export in index.d.ts breaks in Typescript 2.6 with the error "The expression of an export assignment must be an identifier or qualified name in an ambient context."
This commit also adds a small test that uses the default export, since no test existed previously.
Fixes #999