Skip to content

feat: add Badge base component#2730

Merged
dkacper merged 20 commits intov2-developfrom
feat/badge
Jun 1, 2023
Merged

feat: add Badge base component#2730
dkacper merged 20 commits intov2-developfrom
feat/badge

Conversation

@dkacper
Copy link
Copy Markdown
Contributor

@dkacper dkacper commented May 19, 2023 •
edited by aniamusial
Loading

Related issue

Closes SFUI2-638

Scope of work

What's done:

  • Badge component implemented in both React and Vue
  • All blocks implemented
  • Docs page with examples, playground, and API table
  • tests

Screenshots of visual changes

Zrzut ekranu 2023-05-26 o 12 37 26 Zrzut ekranu 2023-05-26 o 12 37 30

Checklist

  • Self code-reviewed
  • Changes documented
  • Semantic HTML
  • SSR-friendly
  • Caching friendly
  • a11y for WCAG 2.0 AA
  • examples created
  • blocks created
  • cypress tests created

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 26, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: d745129

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@storefront-ui/react Minor
@storefront-ui/vue Minor
@storefront-ui/shared Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aniamusial aniamusial marked this pull request as ready for review May 26, 2023 10:40
Szymon-dziewonski
Szymon-dziewonski reviewed May 26, 2023
View reviewed changes
Comment thread packages/sfui/frameworks/react/components/SfIcons/SfIconAddShoppingCart.tsx Outdated
Szymon-dziewonski
Szymon-dziewonski reviewed May 26, 2023
View reviewed changes
Comment thread apps/docs/components/components/badge.md
Szymon-dziewonski
Szymon-dziewonski reviewed May 26, 2023
View reviewed changes
Comment thread packages/sfui/frameworks/vue/components/SfBadge/SfBadge.vue Outdated
Szymon-dziewonski
Szymon-dziewonski reviewed May 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Szymon-dziewonski Szymon-dziewonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not forget add changeset to your PR
here's draft of how to do it https://vsf.atlassian.net/wiki/spaces/SFUI/pages/147750931/Continuous+delivery+pipeline+draft

rest is looking good, great job @aniamusial and @dkacper

Szymon-dziewonski
Szymon-dziewonski reviewed May 26, 2023
View reviewed changes
Comment thread apps/docs/components/components/badge.md Outdated
Szymon-dziewonski
Szymon-dziewonski reviewed May 29, 2023
View reviewed changes
Comment thread packages/sfui/shared/types/index.ts Outdated
Szymon-dziewonski
Szymon-dziewonski reviewed May 29, 2023
View reviewed changes
Comment thread apps/preview/nuxt/pages/showcases/Badge/BadgeBasic.vue
@@ -0,0 +1,32 @@
<template>
<div class="flex gap-3">
<SfButton class="relative" square variant="tertiary">
Copy link
Copy Markdown
Contributor

@Szymon-dziewonski Szymon-dziewonski May 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add relative to SfButton, wdyt ? cc: @FRSgit

Copy link
Copy Markdown
Contributor

@FRSgit FRSgit May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we could - but that would be a breaking change, so let's do it separately on v3.0.0 branch

Szymon-dziewonski
Szymon-dziewonski reviewed May 29, 2023
View reviewed changes
Comment thread apps/preview/nuxt/pages/examples/SfBadge.vue Outdated
Szymon-dziewonski
Szymon-dziewonski reviewed May 29, 2023
View reviewed changes
Comment thread apps/preview/next/pages/examples/SfBadge.tsx Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 30, 2023

[storefront-ui-react] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 30, 2023

[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

dkacper
dkacper commented Jun 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@dkacper dkacper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after all the changes by @aniamusial. I'm happy to approve this PR. Let's merge the badge. ⭐

@dkacper dkacper merged commit 4094afe into v2-develop Jun 1, 2023
@dkacper dkacper deleted the feat/badge branch June 1, 2023 10:12
This was referenced Jun 12, 2023
Merged
Closed
Merged
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRSgit FRSgit Awaiting requested review from FRSgit FRSgit is a code owner

@mattmaribojoc mattmaribojoc Awaiting requested review from mattmaribojoc

@Szymon-dziewonski Szymon-dziewonski Awaiting requested review from Szymon-dziewonski Szymon-dziewonski is a code owner

1 more reviewer

@aniamusial aniamusial aniamusial approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dkacper @Szymon-dziewonski @FRSgit @aniamusial