feat: (sfui2-1089) additional search blocks#2746
Merged
aniamusial merged 11 commits intov2-developfrom May 31, 2023
Merged
Conversation
aniamusial
requested review from
FRSgit,
Szymon-dziewonski,
dkacper and
mattmaribojoc
as code owners
aniamusial
changed the title
🦋 Changeset detectedLatest commit: 1d77252 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!
|
|
[storefront-ui-react] Kudos, SonarCloud Quality Gate passed!
|
dkacper
approved these changes
May 31, 2023
Comment on lines
+160
to
+161
| { id: 'j-dre', name: 'jacket dress', thumbnail: SfIconSearch }, | ||
| { id: 'dr-cat', name: 'dresses', thumbnail: SfIconGridView }, |
Contributor
There was a problem hiding this comment.
I was hoping to find dr-dre 😂
This was referenced Jun 12, 2023
Merged
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
https://vsf.atlassian.net/browse/SFUI2-1089?atlOrigin=eyJpIjoiOWIzOTFkYzEyYmZmNDM1ZjhiMDY1NzUwMDE5Njc5OGQiLCJwIjoiaiJ9
Scope of work
Screenshots of visual changes
Checklist