Skip to content

fix: format SfSelect component #2747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Szymon-dziewonski merged 1 commit into from
May 26, 2023
Merged

fix: format SfSelect component #2747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/nine-flowers-hunt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@storefront-ui/react': patch
'@storefront-ui/vue': patch
---

Format SfSelect component, removal of extra unecessary lines
7 changes: 1 addition & 6 deletions packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,12 @@ export default function SfSelect(props: SfSelectProps) {
...attributes
} = props;
const { isFocusVisible } = useFocusVisible();

const [chevronRotated, setChevronRotated] = useState(false);

const rotateUp = () => setChevronRotated(true);

const rotateDown = () => setChevronRotated(false);

const keydownHandler = (event: KeyboardEvent<HTMLSelectElement>) => {
if (event.code === 'Space') {
rotateUp();
}
if (event.code === 'Space') rotateUp();
};

return (
Expand Down
8 changes: 3 additions & 5 deletions packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,16 @@ const props = defineProps({
default: '',
},
});

const selected = ref(props.value);
const chevronRotated = ref(false);
const emit = defineEmits<{
(event: 'update:modelValue', param: string): void;
}>();

const selected = ref(props.value);
const chevronRotated = ref(false);
const { isFocusVisible } = useFocusVisible();

const clickHandler = () => (chevronRotated.value = true);

const blurHandler = () => (chevronRotated.value = false);

const keydownHandler = () => (chevronRotated.value = true);

const changedValue = (event: Event) => {
Expand Down