Skip to content

fix!: changed paddings in sfselect #2864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aniamusial merged 4 commits into from
Jun 29, 2023
Merged

fix!: changed paddings in sfselect #2864

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
689a11e
fix: changed paddings in sfselect
aniamusial Jun 15, 2023
835ebe2
chore: adjusted padding left
aniamusial Jun 26, 2023
148a542
chore: updated changelog
aniamusial Jun 26, 2023
b55a4d3
Update .changeset/fresh-emus-care.md
aniamusial Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/fresh-emus-care.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@storefront-ui/react': major
'@storefront-ui/vue': major
---

Breaking Change - Padding left adn rigth in SfSelect changed from 14px and 16px to 12px
Comment thread
aniamusial marked this conversation as resolved.
Outdated
2 changes: 1 addition & 1 deletion packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default function SfSelect(props: SfSelectProps) {
required={required}
disabled={disabled}
className={classNames(
'appearance-none disabled:cursor-not-allowed cursor-pointer pl-4 pr-3.5 text-neutral-900 focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-inset ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200',
'appearance-none disabled:cursor-not-allowed cursor-pointer px-3 text-neutral-900 focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-inset ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200',
{
'py-1.5': size === SfSelectSize.sm,
'py-2': size === SfSelectSize.base,
Expand Down
2 changes: 1 addition & 1 deletion packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ const changedValue = (event: Event) => {
:required="required"
:disabled="disabled"
:class="[
'appearance-none disabled:cursor-not-allowed cursor-pointer pl-4 pr-3.5 text-neutral-900 ring-inset focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200',
'appearance-none disabled:cursor-not-allowed cursor-pointer px-3 text-neutral-900 ring-inset focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200',
{
'py-1.5': size === SfSelectSize.sm,
'py-2': size === SfSelectSize.base,
Expand Down