Skip to content

fix!: remove flex classes from SfListItem #2902

Merged
justyna-13 merged 3 commits intov2-release/3.0.0from
fix/remove-flex-classes-from-sf-list-item
Jul 5, 2023
Merged

fix!: remove flex classes from SfListItem #2902
justyna-13 merged 3 commits intov2-release/3.0.0from
fix/remove-flex-classes-from-sf-list-item

Conversation

@justyna-13
Copy link
Copy Markdown
Contributor

@justyna-13 justyna-13 commented Jul 5, 2023

Related issue

Closes # https://vsf.atlassian.net/browse/SFUI2-1203

Scope of work

Screenshots of visual changes

Checklist

  • Self code-reviewed
  • Changes documented
  • Semantic HTML
  • SSR-friendly
  • Caching friendly
  • a11y for WCAG 2.0 AA
  • examples created
  • blocks created
  • cypress tests created

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 5, 2023

🦋 Changeset detected

Latest commit: d1dd114

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@storefront-ui/react Major
@storefront-ui/vue Major
@storefront-ui/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@justyna-13 justyna-13 marked this pull request as ready for review July 5, 2023 13:30
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jul 5, 2023

[storefront-ui-react] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jul 5, 2023

[storefront-ui-vue] Please retry analysis of this Pull-Request directly on SonarCloud.

1 similar comment
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jul 5, 2023

[storefront-ui-vue] Please retry analysis of this Pull-Request directly on SonarCloud.

@justyna-13 justyna-13 changed the title fix!: remove flex classes from SfListItem fix!: remove flex classes from SfListItem Jul 5, 2023
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jul 5, 2023

[storefront-ui-react] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jul 5, 2023

[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@justyna-13 justyna-13 merged commit bbec9e1 into v2-release/3.0.0 Jul 5, 2023
@justyna-13 justyna-13 deleted the fix/remove-flex-classes-from-sf-list-item branch July 5, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants