Skip to content

fix: onClose callback triggered too often [ES-2025]#3332

Merged
FRSgit merged 4 commits intov2-developfrom
fix/ES-2025
Dec 5, 2025
Merged

fix: onClose callback triggered too often [ES-2025]#3332
FRSgit merged 4 commits intov2-developfrom
fix/ES-2025

Conversation

@FRSgit
Copy link
Copy Markdown
Contributor

@FRSgit FRSgit commented Dec 1, 2025

onClose callback now will be triggered only if outside click triggers closing of the dropdown (in react it always have worked like this)
add useDropdown & SfDropdown examples with proper a11y

Related issue

references: https://alokai.atlassian.net/browse/ES-2025

Closes #

Scope of work

Screenshots of visual changes

Checklist

  • Self code-reviewed
  • Changes documented
  • Semantic HTML
  • SSR-friendly
  • Caching friendly
  • [x a11y for WCAG 2.0 AA
  • examples created
  • blocks created
  • cypress tests created

onClose callback now will be triggered only if outside click triggers closing of the dropdown
add useDropdown & SfDropdown examples with proper a11y
@FRSgit FRSgit self-assigned this Dec 1, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Dec 1, 2025

🦋 Changeset detected

Latest commit: 002dc43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@storefront-ui/vue Major
@storefront-ui/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@FRSgit FRSgit merged commit 55fa6a2 into v2-develop Dec 5, 2025
14 checks passed
@FRSgit FRSgit deleted the fix/ES-2025 branch December 5, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants