This repository was archived by the owner on May 28, 2023. It is now read-only.
Added tax calculation with product_tax_id and user group id#307
Merged
pkarw merged 5 commits intoAug 6, 2019
Merged
Conversation
Collaborator
Author
|
This is the PR to for this PR in vue-storefront which implements this on the client side. |
8 tasks
| url = config.elasticsearch.protocol + '://' + url | ||
| } | ||
|
|
||
| // Check price tiers |
Contributor
There was a problem hiding this comment.
@ResuBaka why checking price tiers part is gone?
Collaborator
Author
There was a problem hiding this comment.
I have removed it because I need the user group now too. So it was easier to remove the if and not really needed in the first place, maybe it was needed in some point of the development for the PriceTiers feature or it was there because of performance so you don't need to decode the jwt.
I does not destroy the logic for PriceTiers as it is checked before the actual logic for it is executed anyways.
Contributor
Contributor
|
@ResuBaka can you pleas fix the conflicts? |
…to feature/add-usergroupid-for-product-tax-calculation # Conflicts: # CHANGELOG.md # config/default.json # src/api/catalog.js # src/api/user.js # src/platform/magento1/tax.js # src/platform/magento2/tax.js
pkarw
approved these changes
Aug 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the logic so the tax is right when you have multible rules which depends on the user group id.
With this you can set a default user group id when a use is not logged in.
Then you can enable this but disable the use of the user group id which can be useful when you have cases where you want or need to show the taxes in the frontend but not in the cart as there magento calculates the taxes with the right tax class for the user.