This repository was archived by the owner on May 28, 2023. It is now read-only.
Bugfix for wrong JSON scheme url's and hostname resolution for magento1 platform#443
Merged
Conversation
gibkigonzo
approved these changes
May 25, 2020
This was referenced May 25, 2020
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two things:
The schema extension files won't be found at the moment because the path needs to be relative
fs.existsSync(). Right now thefs.existsSynccheck always returnsfalse.Also the resolution of the VSF bridge URL of the
magento1platform has a flacky RegExp which will return true if a store-code string is found anywhere in the string but it should be match for strings that are surrounded by/only.