Skip to content
This repository was archived by the owner on May 28, 2023. It is now read-only.

Bugfix: Attributes cache tag and multistore handling#583

Merged
Fifciu merged 3 commits into
vuestorefront:hotfix/v1.12.5from
didkan:bugfix/attributes-caching
Nov 2, 2021
Merged

Bugfix: Attributes cache tag and multistore handling#583
Fifciu merged 3 commits into
vuestorefront:hotfix/v1.12.5from
didkan:bugfix/attributes-caching

Conversation

@didkan
Copy link
Copy Markdown
Contributor

@didkan didkan commented Oct 29, 2021 •
edited
Loading

closes #579

  • Adds cache tag attribute when caching so that attributes can be purged using cache tag
  • Adds indexName to cache key so we store multistore attributes separately

This was referenced Oct 29, 2021
Closed
Closed
@didkan
Copy link
Copy Markdown
Contributor Author

didkan commented Nov 2, 2021

@Fifciu Here is the rebased PR you asked for.

@Fifciu Fifciu merged commit 58d7c98 into vuestorefront:hotfix/v1.12.5 Nov 2, 2021
@Fifciu
Copy link
Copy Markdown
Contributor

Fifciu commented Nov 2, 2021

Thanks @didkan , great job!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Fifciu Fifciu Fifciu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@didkan @Fifciu