Skip to content

Load attributes data of attribute-meta for bundled and grouped products #4551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cewald
Copy link
Contributor

@cewald cewald commented Jun 16, 2020

Short Description and Why It's Useful

If I want to show product attribute options of a bundled or grouped products on PDP, the attribute data isn't loaded. But as we already load the children in setGroupedProduct and setBundleProducts we can use the data of the product link request to populate the attributes options data in case it is used. E.g. to show the selected options in the shopping cart.

I added two events hooks: afterSetGroupedProduct and afterSetBundleProducts on which I bound a helper class (getAttributesFromMetadata ) using the attribute/loadProductAttributes action to load the attribute data from response data.

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

@vercel
Copy link

vercel bot commented Jun 16, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/vue-storefront/8wgg8ub3m
✅ Preview: https://vue-storefront-git-fork-icmaa-feature-load-meta-attribu-82e14c.shopware-pwa.vercel.app

@vercel vercel bot temporarily deployed to preview June 16, 2020 15:30 Inactive
@vercel vercel bot temporarily deployed to preview June 16, 2020 15:36 Inactive
@vercel vercel bot temporarily deployed to preview June 16, 2020 16:47 Inactive
@vercel vercel bot temporarily deployed to preview June 17, 2020 08:17 Inactive
@gibkigonzo gibkigonzo merged commit 759870b into vuestorefront:hotfix/v1.12.1 Jun 17, 2020
@cewald cewald deleted the feature/load-meta-attributes-for-product-links-for-v1.12.1 branch June 17, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants