-
-
Notifications
You must be signed in to change notification settings - Fork 168
dependency issue with @vue/composition-api #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
|
@antfu oh I didn't see that. Do you happen to have a plan to support vue@2 without composition api? |
Currently no. |
@antfu Thanks for the comment. Good to know. I should write something small that does the similar thing as vue-demi. |
using vue-demi requires that vue2.6 projects install "@vue/composition-api", always! Even though I believe is the norm in 2.6.x projects but still kind of bummer to get an install error. vue-demi lists @vue/composition-api as optional peer dependency because it would otherwise install it for vue2.7 and vue3.x projects. We could list @vue/composition-api as dependency as well to overcome the install issue, but we're not using anything on this package so why complicate things? 1. I've removed vue-demi altogether, replaced the only thing we've use isVue3 with simply version regexp 1. the swap-vue.js from vuelidate allow us to keep the isomorphic testing to ensure it works everything Related issues: vueuse/vue-demi#67 vueuse/vue-demi#7
using vue-demi requires that vue2.6 projects install "@vue/composition-api", always! Even though I believe is the norm in 2.6.x projects but still kind of bummer to get an install error. vue-demi lists @vue/composition-api as optional peer dependency because it would otherwise install it for vue2.7 and vue3.x projects. We could list @vue/composition-api as dependency as well to overcome the install issue, but we're not using anything on this package so why complicate things? 1. I've removed vue-demi altogether, replaced the only thing we've use isVue3 with simply version regexp 1. the swap-vue.js from vuelidate allow us to keep the isomorphic testing to ensure it works everything Related issues: vueuse/vue-demi#67 vueuse/vue-demi#7
using vue-demi requires that vue2.6 projects install "@vue/composition-api", always! Even though I believe is the norm in 2.6.x projects but still kind of bummer to get an install error. vue-demi lists @vue/composition-api as optional peer dependency because it would otherwise install it for vue2.7 and vue3.x projects. We could list @vue/composition-api as dependency as well to overcome the install issue, but we're not using anything on this package so why complicate things? 1. I've removed vue-demi altogether, replaced the only thing we've use isVue3 with simply version regexp 1. the swap-vue.js from vuelidate allow us to keep the isomorphic testing to ensure it works everything Related issues: vueuse/vue-demi#67 vueuse/vue-demi#7
using vue-demi requires that vue2.6 projects install "@vue/composition-api", always! Even though I believe is the norm in 2.6.x projects but still kind of bummer to get an install error. vue-demi lists @vue/composition-api as optional peer dependency because it would otherwise install it for vue2.7 and vue3.x projects. We could list @vue/composition-api as dependency as well to overcome the install issue, but we're not using anything on this package so why complicate things? 1. I've removed vue-demi altogether, replaced the only thing we've use isVue3 with simply version regexp 1. the swap-vue.js from vuelidate allow us to keep the isomorphic testing to ensure it works everything Related issues: vueuse/vue-demi#67 vueuse/vue-demi#7
Hello, I'm working on supporting both Vue2 and Vue3 in Vue InstantSearch.
I used vue-demi inside Vue InstantSearch. After installing Vue InstantSearch in an empty project, it gives me this error:
More details:
In the
package.json
of Vue InstantSearch,You can see the pull request here. And I deployed the temporary build of the pull request via CodeSandbox, which is:
https://pkg.csb.dev/algolia/vue-instantsearch/commit/3341e045/vue-instantsearch
Now I put it in an example:
p9ez8.zip
If you run
yarn install && yarn serve
it will show the error message above.In Vue InstantSearch, we do not use
@vue/composition-api
, so left it as optional. The error message goes away only when I install it as a dependency inside the example.Do you have any idea? Thanks!
The text was updated successfully, but these errors were encountered: