-
-
Notifications
You must be signed in to change notification settings - Fork 11
MorphMany #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
MorphMany #111
Conversation
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 40 42 +2
Lines 1251 1293 +42
Branches 185 192 +7
=========================================
+ Hits 1251 1293 +42
Continue to review full report at Codecov.
|
import { Model } from '../../Model' | ||
import { Relation, Dictionary } from './Relation' | ||
|
||
export class MorphMany extends Relation { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am noticing a fair amount of code duplication, at some point we might want to DRY these up once the library is feature complete (1.x).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few snags but looks good. Great work.
Additionally, could we add the relevant exports for the relation to index.cjs.ts
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🎉🎉
@ryandialpad Sorry it took long! MorphTo is merged. Could you rebase this one 🙏 |
No worries! Rebased 😃 |
Can we push a new release with this in it? |
What is the timeframe to get this pushed? I am VERY anxious to be able to use this! |
Type of PR:
Breaking changes:
Details
Implements
MorphMany
relationWill rebase when
MorphTo
is merged into master #106