-
Notifications
You must be signed in to change notification settings - Fork 377
Update Swedish, Finnish and English translations #4046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Swedish, Finnish and English translations #4046
Conversation
languages/en.ini
Outdated
| You do not have any items checked out = "You do not have any items checked out" | ||
| You do not have any library cards = "You do not have any library cards" | ||
| You do not have any saved resources = "You do not have any saved resources. Perform a search and use the Save to List button to save items." | ||
| You do not have any saved resources = "You have not saved any favorites. Perform a search and use the Save to List button to save items." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #2020, we addressed a long standing inconsistency where some lines referred to "favorites" and others referred to "saved items" in favor of using "saved items" everywhere. I think it would probably be better not to reintroduce that inconsistency in just one line. If you think it would be better to change "resources" to "items" for consistency with other language, I would not object to that adjustment!
(I also wouldn't close the door on a conversation about bringing back "favorites" but I think if we want to use that term, we need to make a lot more changes than just one line).
In any case, thanks for the various improvements here; I just think we should sort out this detail before moving forward with a merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your feedback. I was not aware of this earlier conversation, but had suspicions about "favorites" not being widely used.
I will amend my request. I think "items" instead of "resources" is an acceptable solution.
demiankatz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @AnnaSmaros, the English translations look consistent to me now!
I notice that the Swedish translation already uses "favoriter" widely, so I trust your judgment on the use of the word there.
Just checking for a second opinion from @EreMaijala on the Finnish before merging this, since I'm not really qualified to look at that myself. :-)
EreMaijala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
Backported to release-10.2. |
No description provided.