Skip to content

Conversation

@AnnaSmaros
Copy link
Contributor

No description provided.

languages/en.ini Outdated
You do not have any items checked out = "You do not have any items checked out"
You do not have any library cards = "You do not have any library cards"
You do not have any saved resources = "You do not have any saved resources. Perform a search and use the Save to List button to save items."
You do not have any saved resources = "You have not saved any favorites. Perform a search and use the Save to List button to save items."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #2020, we addressed a long standing inconsistency where some lines referred to "favorites" and others referred to "saved items" in favor of using "saved items" everywhere. I think it would probably be better not to reintroduce that inconsistency in just one line. If you think it would be better to change "resources" to "items" for consistency with other language, I would not object to that adjustment!

(I also wouldn't close the door on a conversation about bringing back "favorites" but I think if we want to use that term, we need to make a lot more changes than just one line).

In any case, thanks for the various improvements here; I just think we should sort out this detail before moving forward with a merge!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback. I was not aware of this earlier conversation, but had suspicions about "favorites" not being widely used.
I will amend my request. I think "items" instead of "resources" is an acceptable solution.

@demiankatz demiankatz requested a review from EreMaijala October 30, 2024 11:17
Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @AnnaSmaros, the English translations look consistent to me now!

I notice that the Swedish translation already uses "favoriter" widely, so I trust your judgment on the use of the word there.

Just checking for a second opinion from @EreMaijala on the Finnish before merging this, since I'm not really qualified to look at that myself. :-)

Copy link
Contributor

@EreMaijala EreMaijala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@demiankatz demiankatz modified the milestones: 10.1, 11.0 Oct 31, 2024
@demiankatz demiankatz merged commit e24d3a9 into vufind-org:dev-11.0 Oct 31, 2024
4 checks passed
@demiankatz demiankatz modified the milestones: 11.0, 10.2 Mar 26, 2025
@demiankatz
Copy link
Member

Backported to release-10.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants