[VUFIND-1789] Use EDS default setting for searchmode in advanced search #4572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
requested changes
Aug 27, 2025
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @kmcarnes!
Looks like the build is failing here because of a minor style issue (missing use statement for function). You can run composer fix and commit the results to get things passing.
Member
|
@kmcarnes, style issue aside, this logic looks good and it's working correctly for me -- so I'll approve and merge this as soon as the fix is pushed up. I'm also happy to help as needed -- just figured asking you to do it would be a useful learning experience on your first PR. :-) |
kmcarnes
force-pushed
the
eds-default-searchmode
branch
from
b26d3c5 to
f7156e6
Compare
Contributor
Author
|
Thanks @demiankatz, I learn best by doing. |
Member
|
Since there is going to be a 10.2.1 release, I have backported this fix. |
demiankatz
pushed a commit
that referenced
this pull request
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making a new advanced search with EDS, the default search mode is not selected because it assumes that if there is a search object that it will specify the search mode, but the search object can be created with other defaults that don't include the search mode.
This changes the function to check the search object for a search mode and select the default if none were found.
TODO: