Remove StreamHandlerTest::testInvalidFilePath #4842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes VuFindTest\Log\Handler\SteamHandlerTest::testInvalidFilePath because it was unportable, failed when PHP is run as root (e.g. in a container), and didn't test any relevant VuFind functionality.
Contributor
Author
|
Heh, I misspelled the module in the commit title... |
demiankatz
changed the title
demiankatz
requested changes
Nov 11, 2025
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
As we discussed on Slack, I'll wait to see how this impacts code coverage before reviewing further. If it has no impact on coverage, I'm fine with removing it. If it does cover some logic, we should figure out a different way of testing the logic (perhaps by sending an invalid stream URI, for example).
Contributor
Author
|
No change seen in coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes VuFindTest\Log\Handler\SteamHandlerTest::testInvalidFilePath because it was unportable, failed when PHP is run as root (e.g. in a container), and didn't test any relevant VuFind functionality.