Skip to content

Conversation

@sdpkjc
Copy link
Collaborator

@sdpkjc sdpkjc commented Jun 5, 2023

Description

Poetry 1.3 has led to a bug our CI fails, see python-poetry/poetry#7171

python-poetry/poetry#7169 fixed the issue, I suggest to bump poetry directly to 1.4 and get our CI healthy again.

Types of changes

  • Bug fix
  • New feature
  • New algorithm
  • Documentation

Checklist:

  • I've read the CONTRIBUTION guide (required).
  • I have ensured pre-commit run --all-files passes (required).
  • I have updated the tests accordingly (if applicable).
  • I have updated the documentation and previewed the changes via mkdocs serve.
    • I have explained note-worthy implementation details.
    • I have explained the logged metrics.
    • I have added links to the original paper and related papers.

If you need to run benchmark experiments for a performance-impacting changes:

  • I have contacted @vwxyzjn to obtain access to the openrlbenchmark W&B team.
  • I have used the benchmark utility to submit the tracked experiments to the openrlbenchmark/cleanrl W&B project, optionally with --capture-video.
  • I have performed RLops with python -m openrlbenchmark.rlops.
    • For new feature or bug fix:
      • I have used the RLops utility to understand the performance impact of the changes and confirmed there is no regression.
    • For new algorithm:
      • I have created a table comparing my results against those from reputable sources (i.e., the original paper or other reference implementation).
    • I have added the learning curves generated by the python -m openrlbenchmark.rlops utility to the documentation.
    • I have added links to the tracked experiments in W&B, generated by python -m openrlbenchmark.rlops ....your_args... --report, to the documentation.

@vercel
Copy link

vercel bot commented Jun 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cleanrl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 3:07pm

@sdpkjc sdpkjc changed the title bump poetry to 1.4 bump poetry to 1.3.1 Jun 5, 2023
@sdpkjc
Copy link
Collaborator Author

sdpkjc commented Jun 5, 2023

The Modern installer in poetry 1.4 causes our CI to fail under Windows. python-poetry/poetry#7611

1.3.1 does not have this problem and fixes the bug mentioned earlier.

Now our CI is working and we're ready to merge.

@sdpkjc sdpkjc requested a review from vwxyzjn June 5, 2023 15:26
@sdpkjc sdpkjc merged commit acdad65 into master Jun 5, 2023
ludgerpaehler pushed a commit to ludgerpaehler/koopman-rl that referenced this pull request Jan 13, 2026
* bump poetry to 1.4

* test! bump poetry to 1.5.1

* fix! bump poetry to 1.4

* downgrade to 1.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants