Skip to content

Conversation

@jestabro
Copy link
Contributor

@jestabro jestabro commented Aug 7, 2025

Change summary

An addendum to
#4636
this will be needed for correct behavior of the op-mode-runner on paths shared across files, for example:

Before:

vyos@vyos:~$ /usr/bin/vyos-op-run show interfaces 
Incomplete command: show interfaces

After the bug fix herein:

vyos@vyos:~$ /usr/bin/vyos-op-run show interfaces
Codes: S - State, L - Link, u - Up, D - Down, A - Admin Down
Interface    IP Address          MAC                VRF        MTU  S/L    Description
-----------  ------------------  -----------------  -------  -----  -----  -------------
eth0         192.168.122.218/24  52:54:00:df:6e:8c  default   1500  u/u
eth1         -                   52:54:00:22:5a:62  default   1500  u/u
eth2         -                   52:54:00:c7:9e:eb  default   1500  u/u
eth3         -                   52:54:00:15:2b:df  default   1500  u/u
lo           127.0.0.1/8         00:00:00:00:00:00  default  65536  u/u
             ::1/128

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Aug 7, 2025
@github-actions
Copy link

github-actions bot commented Aug 7, 2025

👍
No issues in PR Title / Commit Title

@github-actions
Copy link

github-actions bot commented Aug 8, 2025

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes op-mode Incomplete command.
I didn't check this code manually

@jestabro jestabro merged commit 6fa4978 into vyos:current Aug 8, 2025
17 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants