T6792: Autocomplete for "show arp interface" interfaces #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
sever-sever
previously requested changes
Dec 12, 2024
|
|
||
| let filter_broadcast s = | ||
| let pattern = {|^(bond|br|eth)(.*)$|} | ||
| let pattern = {|^(bond|br|dum|eth|gnv|peth|macsec|vxlan|wwan|wlan)(.*)$|} |
Member
There was a problem hiding this comment.
Are you sure the dum interface (and others) supports ARP?
vyos@r14:~$ show int
Codes: S - State, L - Link, u - Up, D - Down, A - Admin Down
Interface IP Address MAC VRF MTU S/L Description
----------- ----------------- ----------------- ------- ----- ----- -------------
dum0 203.0.113.1/24 be:62:fd:ba:50:50 default 1500 u/u
eth0 192.168.122.14/24 52:54:00:77:fa:36 default 1500 u/u
lo 127.0.0.1/8 00:00:00:00:00:00 default 65536 u/u
::1/128
veth0 - 0a:d6:2d:f8:bd:e3 default 1500 u/u
vyos@r14:~$
vyos@r14:~$
vyos@r14:~$ ping 203.0.113.1
PING 203.0.113.1 (203.0.113.1) 56(84) bytes of data.
64 bytes from 203.0.113.1: icmp_seq=1 ttl=64 time=0.034 ms
64 bytes from 203.0.113.1: icmp_seq=2 ttl=64 time=0.041 ms
^C
--- 203.0.113.1 ping statistics ---
2 packets transmitted, 2 received, 0% packet loss, time 1018ms
rtt min/avg/max/mdev = 0.034/0.037/0.041/0.003 ms
vyos@r14:~$
vyos@r14:~$
vyos@r14:~$
vyos@r14:~$ show arp interface dum0
Address Interface Link layer address State
--------- ----------- -------------------- -------
vyos@r14:~$
vyos@r14:~$
vyos@r14:~$ show arp
Address Interface Link layer address State
-------------- ----------- -------------------- ---------
192.168.122.15 eth0 52:54:00:55:80:8c DELAY
192.168.122.1 eth0 52:54:00:16:84:08 REACHABLE
vyos@r14:~$
Needs to check other interfaces before adding
Contributor
Author
There was a problem hiding this comment.
dum removed from allow list
dmbaturin
requested changes
Dec 16, 2024
extended filter for possible broadcast-capable interfaces
dmbaturin
approved these changes
Dec 17, 2024
dmbaturin
dismissed
sever-sever’s stale review
Change request is already addressed
sever-sever
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extended filter for possible broadcast-capable interfaces
Change Summary
Types of changes
Related Task(s)
Related PR(s)
Proposed changes
How to test
add an interface with allowed type e.g dummy:
see possible completion:
add and check ARP records
Checklist: