T8110: "list_interfaces --bondable" must not return VLAN subinterfaces #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by the regex used for "set interfaces ethernet" adjust the regex to match for interfaces acting as a bond member interface. This has been changed to also include (in addition to eth) lan, eno, ens prefixed physical interfaces.
jestabro
approved these changes
Dec 19, 2025
Contributor
jestabro
left a comment
jestabro
left a comment
There was a problem hiding this comment.
This fixes the original problem, and generalizes the regex in a reasonable way.
dmbaturin
approved these changes
Dec 30, 2025
Member
dmbaturin
left a comment
dmbaturin
left a comment
There was a problem hiding this comment.
The patch certainly fixes the problem. I have reservations about extending the regex to support patterns other than eth since we don't use those names. It shouldn't be a problem since we ensure all physical Ethernet interfaces are called ethX, though.
dmbaturin
reviewed
Dec 30, 2025
|
|
||
| let filter_bondable s = | ||
| let pattern = {|^(eth)(.*)$|} | ||
| let pattern = {|^(eth|lan|eno|ens)[A-Za-z0-9_-]*$|} |
Member
There was a problem hiding this comment.
Suggested change
| let pattern = {|^(eth|lan|eno|ens)[A-Za-z0-9_-]*$|} | |
| let pattern = {|^(eth)[A-Za-z0-9_-]*$|} |
I think we can leave it to just eth until and unless we decide to start supporting different Ethernet interface name prefixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Inspired by the regex used for
set interfaces ethernet[1] adjust the regex to match for interfaces acting as a bond member interface. This has been changed to also include (in addition to eth) lan, eno, ens prefixed physical interfaces.1: https://github.com/vyos/vyos-1x/blob/617c99b89aa2b9df985f573159d78212983a5451/interface-definitions/interfaces_ethernet.xml.in#L17
Types of changes
Related Task(s)
Related PR(s)
Tests
Before:
After:
Checklist: