feat: add update credential status endpoint #110
Conversation
Lets do whatever will be most confusing for developers :) |
IMO, Yes.... Support for a type is sufficient to convey support for the enumeration of values.... thats the whole point of creating unqiue type names :) |
|
@tplooker if you can provide some sample JSON / curls that would be awesome. |
|
@OR13, can you elaborate on what you mean? Is this sufficient? https://github.com/w3c-ccg/vc-http-api/pull/110/files#diff-74dfbc770d6e21cb974f297ba8f1bc7015ece556537a6202e87b78622728a0cfR154 |
|
@tplooker I guess I was hoping for test suite JSON examples... but maybe better in a separate PR... |
|
Ah gotcha, yes fixtures and tests will be added after this PR. |
|
Would love some feedback from @msporny and @peacekeeper on this one, not trying to rush the process, just aware that this is time critical |
|
we are blocked by this, both functionally, and from a purpose of being able to run a cleanup and consistency pass on the YAML definition file, and on beginning to finalize documentation on a more complete version of the API that matches our bare minimum use case needs. |
|
Another outstanding question for this endpoint is should it be |
|
|
|
Ready for re-review @msporny @OR13 @peacekeeper |
|
Also I have local test cases for revocation almost ready so if we can get this reviewed soon then I will file the next PR |
|
@peacekeeper @msporny looking for re-reviews here PR been open 8 days, made changes yesterday as per @OR13 review and now approval, anything else from you needed before approval and merging? |
Co-authored-by: Manu Sporny <[email protected]>
Co-authored-by: Manu Sporny <[email protected]>
tplooker
force-pushed
the
tl/add-update-status-endpoint
branch
from
5870b49 to
7105bdb
Compare
|
Multiple reviews and approvals 8 days open, merging. |
This PR adds a credential issuer API for managing an update to the status of an issued credential.
Outstanding Questions
How should the status property relate to the type property in the request? Are we assuming that the type sets the valid enumeration of values for status?YesIs the credentialId the id of the issued credential?Yes