Skip to content

Apply [SameObject] IDL extended attribute to relevant attributes #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
inexorabletash opened this issue Apr 21, 2017 · 1 comment
Closed

Apply [SameObject] IDL extended attribute to relevant attributes #194

inexorabletash opened this issue Apr 21, 2017 · 1 comment
Assignees
@inexorabletash
Labels
needs-pr

Comments

@inexorabletash
Copy link
Member

We can apply [SameObject] in the following cases:

  • IDBObjectStore's transaction
  • IDBIndex's objectStore
  • IDBTransaction's db

Although semantically "same object" I don't think we can apply it in these cases per IDL's rules.

  • IDBRequest and IDBCursor's source - it's a nullable union
  • IDBObjectStore and IDBIndex's keyPath - it is any and defined in prose as effectively (DOMString or sequence<DOMString>) (nullable for stores)
@inexorabletash inexorabletash self-assigned this Apr 21, 2017
@inexorabletash
Copy link
Member Author

PR: #195

inexorabletash added a commit that referenced this issue Apr 21, 2017
@inexorabletash
Use [SameObject]/[NewObject] in IDL where appropriate (Fixes #193, #194)
05b2a7c 
Applies the [SameObject] IDL extended attribute to readonly attributes that always return the same instance, and the [NewObject] attribute to methods that always return new objects. These are described by algorithms already, but these annotations allow implementations and tests to verify the behavior.
@xfq xfq mentioned this issue Oct 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inexorabletash inexorabletash

Labels
needs-pr
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@inexorabletash