Disambiguate "running" for transactions #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The phrase "a transaction is running" was not normatively defined and confusing given the complex lifecycle of transactions. Introduce a new definition for "live" which covers from a transactions creation until it is finished. Also, rename "running an upgrade transaction" since steps are often invoked with "run" and that could get awkward. Simplify to "upgrade a database". No behavior changes, just normative terminology definitions. Resolves #408. Thanks to @evanstade the issue and suggestions.
|
@evanstade could you take a look? |
evanstade
reviewed
Aug 2, 2023
evanstade
approved these changes
Aug 2, 2023
Co-authored-by: Austin Sullivan <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Aug 3, 2023
SHA: 43dfcf1 Reason: push, by inexorabletash Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 task
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The phrase "a transaction is running" was not normatively defined and confusing given the complex lifecycle of transactions. Introduce a new definition for "live" which covers from a transactions creation until it is finished.
Also, rename "running an upgrade transaction" since steps are often invoked with "run" and that could get awkward. Simplify to "upgrade a database".
No behavior changes, just normative terminology definitions.
Resolves #408. Thanks to @evanstade the issue and suggestions.
The following tasks have been completed:
Preview | Diff