Update the strategy argument to 'construct a ReadableStream'. #1338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
lgtm |
annevk
reviewed
Aug 9, 2018
docs/index.bs
Outdated
| 1. When |promise| is fulfilled with a value that matches with neither of the above patterns, or |promise| is rejected, [=ReadableStream/error=] |newStream| with a <code>TypeError</code>. | ||
| 1. Let |cancel| be an action that [=ReadableStream/cancels=] |response|'s [=response/body=]'s <a>stream</a> with |reader|. | ||
| 1. Let |newStream| be the result of [=ReadableStream/construct a ReadableStream object=] with |strategy|, |pull| and |cancel| in |targetRealm|. | ||
| 1. Let |newStream| be the result of [=ReadableStream/construct a ReadableStream object=] with |highWaterMark|, |sizeAlgorithm|, |pull| and |cancel| in |targetRealm|. |
Member
There was a problem hiding this comment.
I'd add a comma after |pull|. (I realize that's a new nit though as the old text had the same issue.)
annevk
pushed a commit
to whatwg/fetch
that referenced
this pull request
Aug 10, 2018
Collaborator
|
Thanks for the PR @jyasskin! Could you remove the html file from the change set? Now Travis CI builds the spec when it's merged. (I just changed the CONTRIBUTING.md document.) |
jyasskin
force-pushed
the
readable-stream-strategy
branch
from
b43bff9 to
fcd5787
Compare
Member
Author
|
@jungkees Done. |
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match whatwg/fetch#781.
@ricea
Preview | Diff