Skip to content

Fix wording in expansion #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kasei opened this issue Oct 28, 2019 · 1 comment · Fixed by #179
Closed

Fix wording in expansion #178

kasei opened this issue Oct 28, 2019 · 1 comment · Fixed by #179

Comments

@kasei
Copy link
Contributor

kasei commented Oct 28, 2019

In the expansion algorithm, the wording of step 13.4.3 seems to be missing something:

If result already has an expanded property entry, for @included or @type.
@gkellogg
Copy link
Member

I think that this step is unnecessary, and a remnant of some editing phase. There are cases below for both @type and @included.

gkellogg added a commit that referenced this issue Oct 28, 2019
@gkellogg
Remove incomplete and redundant step for @type and @included in e…
cb8ba95 
…xpansion algorithm.

Fixes #178.
@gkellogg gkellogg mentioned this issue Oct 28, 2019
Merged
gkellogg added a commit that referenced this issue Oct 29, 2019
@gkellogg
Remove incomplete and redundant step for @type and @included in e…
2f36a51 
…xpansion algorithm.

Fixes #178.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove incomplete and redundant step for @type and @included w3c/json-ld-api
2 participants
@kasei @gkellogg