Skip to content

Duplicated content in Expansion algorithm steps #243

Closed

Description

@kasei

The Expansion Algorithm step 13.4.4 includes these two sub-steps:

  • 13.4.4.4) Otherwise, set expanded value to the result of using the IRI Expansion algorithm, passing type-scoped context for active context, true for vocab, and true for document relative to expand the value or each of its items. If result already has an entry for @type, prepend the value of @type in result to expanded value, transforming it into an array, if necessary.
  • 13.4.4.5) If result already has an entry for @type, prepend the value of @type in result to expanded value, transforming it into an array, if necessary.

The latter step seems to be included in the former step. Given the context of 13.4.4.4, this seems surely to be accidental.

Activity

  1. iherman commented on Dec 13, 2019

    @iherman
    Member

    This issue was discussed in a meeting.

    • RESOLVED: remove repeated text from expansion 13.4.4.4
    View the transcript Return of the adding an entry step
    Rob Sanderson: #243
    Rob Sanderson: https://w3c.github.io/json-ld-api/#expansion-algorithm
    Rob Sanderson: in the expansion algorithm, step 13.4.4.4 and 13.4.4.5
    … there is the same text repeated
    … looks like a copy-paste error
    Proposed resolution: remove repeated text from expansion 13.4.4.4 (Rob Sanderson)
    Gregg Kellogg: +1
    Harold Solbrig: +1
    Rob Sanderson: +1
    Tim Cole: +1
    David I. Lehn: +1
    Pierre-Antoine Champin: +1
    Benjamin Young: +!
    Benjamin Young: +1
    Resolution #4: remove repeated text from expansion 13.4.4.4
  2. gkellogg commented on Dec 18, 2019

    @gkellogg
    Member

    @kasei, please let us know if changes in #249 satisfactorily address your concern.

  3. kasei commented on Dec 18, 2019

    @kasei
    ContributorAuthor

    Looks good, thanks.

  4. iherman commented on Dec 20, 2019

    @iherman
    Member

    This issue was discussed in a meeting.

    • RESOLVED: Close completed editorial issues API#242, #243, #244, #245, #246
    View the transcript Close editorial issues
    Proposed resolution: Close completed editorial issues API#242, #243, #244, #245, #246 (Rob Sanderson)
    Ruben Taelman: +1
    Gregg Kellogg: +1
    Ivan Herman: +1
    Pierre-Antoine Champin: +1
    Jeff Mixter: +1
    Tim Cole: +1
    Rob Sanderson: +1
    Adam Soroka: +1
    Resolution #9: Close completed editorial issues API#242, #243, #244, #245, #246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions