Skip to content

Markup missing for variable in Create Term Definition #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kasei opened this issue Dec 19, 2019 · 5 comments · Fixed by #271
Closed

Markup missing for variable in Create Term Definition #260

kasei opened this issue Dec 19, 2019 · 5 comments · Fixed by #271

Comments

@kasei
Copy link
Contributor

kasei commented Dec 19, 2019

Markup is missing from Create Term Definition step 28 for value to indicate it as a variable.

@gkellogg
Copy link
Member

We say "the value" and not "value", but it probably should be consistent with the previous steps.

Note that, other than the removal of "the", this is purely formatting. The clickable nature of variables is only true for the ED, not anything that's published, so it is a simple formatting change, and marking it as a change since CR would be excessive, IMO.

@kasei
Copy link
Contributor Author

kasei commented Dec 20, 2019

The clickable nature of variables is only true for the ED, not anything that's published, so it is a simple formatting change, and marking it as a change since CR would be excessive, IMO.

Understood. However, I'm very saddened to hear that the clickable variables will not make it through to the REC documents. As a point of feedback on implementing JSON-LD purely from the spec document, I can't imagine having gotten through it without the clickable variables. If there is any way to get this feature into the publishing process leading to the REC docs, please consider doing it.

@gkellogg
Copy link
Member

I agree, but the ReSpec folks have their reasons, based upon their interpretation of W3C norms. You might raise an issue there for clarification.

Of course, we have some other active aspect to our specs which don’t seem to be an issue, so I would support a change to ReSpec to keep this when publishing.

@kasei
Copy link
Contributor Author

kasei commented Dec 20, 2019

OK, thanks. I'll look into raising an issue there, or discussing with @azaroth42 about pushing for a change.

@iherman
Copy link
Member

iherman commented Dec 20, 2019

This issue was discussed in a meeting.

  • RESOLVED: Add formatting to create term def step 28 (no entry in changelog as the /text/ doesn’t change)
View the transcript Missing markup in step 28
Rob Sanderson: #260
Rob Sanderson: This next issue is also very editorial.
… The value in the linked step has no markup.
Gregg Kellogg: The formatting that allows you to click on it, and see other usages, is only available on GitHub, and will go away once we go to Rec.
… It would be good to look into making this survive the transition.
Proposed resolution: Add formatting to create term def step 28 (no entry in changelog as the /text/ doesn’t change) (Rob Sanderson)
Gregg Kellogg: +1
Rob Sanderson: +1
Jeff Mixter: +1
Ruben Taelman: +1
Tim Cole: +1
Pierre-Antoine Champin: +1
Adam Soroka: +1
Resolution #7: Add formatting to create term def step 28 (no entry in changelog as the /text/ doesn’t change)

gkellogg added a commit that referenced this issue Dec 20, 2019
gkellogg added a commit that referenced this issue Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants