Add tests to check for keyword redefinition allowing @protected.
#158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkellogg
added a commit
that referenced
this pull request
Sep 29, 2019
gkellogg
added a commit
that referenced
this pull request
Sep 30, 2019
gkellogg
added a commit
that referenced
this pull request
Sep 30, 2019
gkellogg
force-pushed
the
protected-keywords
branch
from
49e6ec1 to
3a748f4
Compare
pchampin
approved these changes
Oct 3, 2019
| "@type": {"@container": "@set", "@protected": true} | ||
| }, { | ||
| "@version": 1.1, | ||
| "@type": {"@protected": true} |
There was a problem hiding this comment.
Why is it considered as an attempt to override @type?
Is it because it implies the opposite of "@container": "@set"?
There was a problem hiding this comment.
Yes,
Because it would change the container association with @type. But, this might not be important, because it wouldn’t change the interpretation when expanding, but could create an alternate representation when compacting.
There was a problem hiding this comment.
+1 to @gkellogg -- and better not to have subtle surprises like that.
dlongley
approved these changes
Oct 4, 2019
| "@type": {"@container": "@set", "@protected": true} | ||
| }, { | ||
| "@version": 1.1, | ||
| "@type": {"@protected": true} |
There was a problem hiding this comment.
+1 to @gkellogg -- and better not to have subtle surprises like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For w3c/json-ld-syntax#246.
Preview | Diff