Skip to content

Change inline note to block note in Create Term Definition step 16. #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 24, 2019
Merged

Change inline note to block note in Create Term Definition step 16. #273

merged 2 commits into from
Dec 24, 2019

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Dec 23, 2019 •
edited by pr-preview bot
Loading

For #241.

@davidlehn and @kasei, I change the inline note to a block note, but I don't think it improves it. Please suggest any other changes you think would improve both formatting and clarity.

Preview | Diff

@kasei
Copy link
Contributor

kasei commented Dec 23, 2019

@gkellogg I do think this is an improvement. I think I would also update the note text (as it is more free-standing now) to begin "If the '@id' entry in value is null..."

@gkellogg gkellogg merged commit f33a219 into master Dec 24, 2019
@gkellogg gkellogg deleted the issue241-take2 branch December 24, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlehn davidlehn Awaiting requested review from davidlehn

@pchampin pchampin Awaiting requested review from pchampin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkellogg @kasei