-
Notifications
You must be signed in to change notification settings - Fork 34
More context processing #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 14, 2020
…onLdOptions/base`, which now defaults to `null`. Fixes #375.
…_ and _original base URL_ of the new _active context_ is unconditional, unlinke _previous_context_.
… that the previous document was cached in 5.2.3 of the Create Context Algorithm. Fixes #372.
…absolute) when it can't be resolved against _base URL_, because it is also not a valid IRI. Update `expand()` to pass the _original base URL_ from the current _active context_ when creating a new _active context_ using _expandContext_. Fixes #373.
…gorithm from `expand()`. Fixes #374.
This was referenced Feb 15, 2020
… IRI_ property of an _active context_. For #371.
pchampin
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me, modulo a slight change line 1256.
Co-Authored-By: Pierre-Antoine Champin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@type: @id
and set option values to be relative to the manifest location. Fixes Base URL is not always absolute in Context Processing #369.expand()
processing if there is nodocumentUrl
. This usesJsonLdOptions/base
, which could be null, or something else appropriate for when theinput
orexpandContext
is not a URL. For Unclear how to set original base URL in Context Processing #370.documentUrl
is not available, values come fromJsonLdOptions/base
, which now defaults tonull
. Fixes No default value defined for base URL in Create Term Definition #375.expand()
to pass the original base URL from the current active context when creating a new active context using expandContext. Fixes Possible use of non-URL values as the base URL in expand() #373.null
for active property on initial call to the Expansion algorithm fromexpand()
. Fixes Missing use of required Expansion input variable in expand() #374.Preview | Diff