Skip to content

More context processing #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 18, 2020
Merged

More context processing #377

merged 11 commits into from
Feb 18, 2020

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Feb 14, 2020


Preview | Diff

… This uses `JsonLdOptions/base`, which could be null, or something else appropriate for when the `input` or `expandContext` is not a URL.

For #370.
…onLdOptions/base`, which now defaults to `null`.

Fixes #375.
…_ and _original base URL_ of the new _active context_ is unconditional, unlinke _previous_context_.
… that the previous document was cached in 5.2.3 of the Create Context Algorithm.

Fixes #372.
…absolute) when it can't be resolved against _base URL_, because it is also not a valid IRI.

Update `expand()` to pass the _original base URL_ from the current _active context_ when creating a new _active context_ using _expandContext_.

Fixes #373.
Copy link
Contributor

@pchampin pchampin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, modulo a slight change line 1256.

Co-Authored-By: Pierre-Antoine Champin <[email protected]>
@gkellogg gkellogg merged commit 2fb0435 into master Feb 18, 2020
@gkellogg gkellogg deleted the more-context-processing branch February 18, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants