Skip to content

Update implementation report on streaming parser #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rubensworks
Copy link
Member

jsonld-streaming-parser.js now passes all toRdf tests.

@gkellogg I see that the updated HTML only reports 367 toRdf test, while my test suite runner reports 377 tests (7 skipped). Is it possible that something else needs to be updated?

@gkellogg
Copy link
Member

There is a cache of the merged manifests in triples form that needs to be updated to report on all the tests. I’ll take care of it shortly.

@gkellogg
Copy link
Member

@rubensworks Try rebasing and running again.

Note that your skipped reports include those for specVersion json-ld-1.0.

We'll need to do this again after PR #416 is merged.

@rubensworks
Copy link
Member Author

Done.

We'll need to do this again after PR #416 is merged.

Yes. I plan to add some more tests in the next couple of days as well.

@rubensworks rubensworks force-pushed the report/jsonld-streaming-parser-final branch from 4c16399 to fdcad38 Compare March 16, 2020 07:38
@gkellogg gkellogg merged commit 25403b0 into w3c:master Mar 16, 2020
@rubensworks rubensworks deleted the report/jsonld-streaming-parser-final branch March 16, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants