Update IRI Expansion to not return values including a : that are not absolute IRIs #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t absolute IRIs, but continue processing. Fixes w3c/json-ld-syntax#66.
|
@iherman small change to fix this issue; what's in the Changes section could go in errata. |
iherman
reviewed
Oct 4, 2018
index.html
Outdated
| @@ -1514,7 +1514,8 @@ <h3>Algorithm</h3> | |||
| for <var>prefix</var>, return the result of concatenating | |||
| the <a>IRI mapping</a> associated with <var>prefix</var> and | |||
| <var>suffix</var>.</li> | |||
| <li>Return <var>value</var> as it is already an <a>absolute IRI</a>.</li> | |||
| <li><span class="changed">If <var>value</var> as the form of an <a>absolute IRI</a></span>, | |||
There was a problem hiding this comment.
Shouldn't that be "If value has the form of an..."?
@gkellogg, I am not sure what you are asking. Do you mean that this should be included in the errata for the API rec? (I guess the answer is yes...) |
|
Yes, as we discussed in the call, this should be considered to be an errata on the API spec. |
|
In my view, 1. record the erratum and 2. merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
but continue processing.
Fixes w3c/json-ld-syntax#66.
Preview | Diff