Reject empty term #421
Merged
Reject empty term #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My goal was to avoid changing the step numbering. The drawback is that the two operations in this if-otherwise may seem only vaguely related...
|
This PR addresses #379 |
gkellogg
approved these changes
Mar 16, 2020
|
Need to add the same toRdf test. Also "e052" will bump into the recursion test PR naming. May be easier to handle that here with less tests to rename? Sad to see such a nice obfuscated json-ld feature get testsuited away. |
Yes, we should compare with other PRs and rename as appropriate, and add a toRdf version. (It would be nice to have a way to not have to do this manually!)
👍 But, that's what the spec says to do; perhaps 2.0 can roll that back. |
davidlehn
reviewed
Mar 17, 2020
| @@ -5353,6 +5353,27 @@ <h2> | |||
| </dd> | |||
| </dl> | |||
| </dd> | |||
| <dt id='te052'> | |||
|
I'm rebuilding them all as part of PR #416. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💥 Error: write EPROTO 140222018242432:error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version:../deps/openssl/openssl/ssl/s23_clnt.c:772:
💥 ###
PR Preview failed to build. (Last tried on Mar 16, 2020, 11:38 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 HTML Diff Service - The HTML Diff Service is used to create HTML diffs of the spec changes suggested in a pull request.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.