-
Notifications
You must be signed in to change notification settings - Fork 34
Fix compacting property-based indexes. #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c9c73f8
Change references to {{LoadDocumentCallback/url}} because ReSpec does…
gkellogg 81ccb0b
Added additional language to the Compaction Algorithm step 12.8.9.6.1…
gkellogg 92cfed9
Add tests for round-tripping property indexes. For #514.
gkellogg e24a399
Fix erratum reference.
gkellogg 45036dc
Fix complaints about playground local reference.
gkellogg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "@context": { | ||
| "ex": "http://example.org/ns/", | ||
| "prop": { | ||
| "@id": "ex:prop", | ||
| "@container": "@index", | ||
| "@index": "ex:name" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "http://example.org/ns/prop": [{ | ||
| "@id": "http://example.org/ns/bar", | ||
| "http://example.org/ns/name": "bar" | ||
| }, { | ||
| "@id": "http://example.org/ns/foo", | ||
| "http://example.org/ns/name": "foo" | ||
| }] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "@context": { | ||
| "ex": "http://example.org/ns/", | ||
| "prop": { | ||
| "@id": "ex:prop", | ||
| "@container": "@index", | ||
| "@index": "ex:name" | ||
| } | ||
| }, | ||
| "prop": { | ||
| "foo": { "@id": "ex:foo"}, | ||
| "bar": { "@id": "ex:bar"} | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "@context": { | ||
| "ex": "http://example.org/ns/", | ||
| "prop": { | ||
| "@id": "ex:prop", | ||
| "@container": "@index", | ||
| "@index": "http://example.org/ns/name" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "http://example.org/ns/prop": [{ | ||
| "@id": "http://example.org/ns/bar", | ||
| "http://example.org/ns/name": "bar" | ||
| }, { | ||
| "@id": "http://example.org/ns/foo", | ||
| "http://example.org/ns/name": "foo" | ||
| }] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "@context": { | ||
| "ex": "http://example.org/ns/", | ||
| "prop": { | ||
| "@id": "ex:prop", | ||
| "@container": "@index", | ||
| "@index": "http://example.org/ns/name" | ||
| } | ||
| }, | ||
| "prop": { | ||
| "foo": { "@id": "ex:foo"}, | ||
| "bar": { "@id": "ex:bar"} | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative to consider, which is probably more correct, would be to do the expansion of the
@indexvalue when the context is processed, as the value may expand differently than it would when compacting. It would still be a localized change, but not to the Compaction algorithm.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did try this, but remembering the original compacted term is necessary for expansion. The most correct solution would be to save the expanded version of this in the term definition, and use that in the Compaction algorithm instead of the original version, but that would be more disruptive to the rest of the document. This solution will solve any issues other than those specifically constructed to defeat it.