-
Notifications
You must be signed in to change notification settings - Fork 34
Protected term errors #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2122c34
Make `@protected` test strict.
davidlehn c72fe5c
Add more `@protected` tests.
davidlehn 2d4cc1e
Add more `@protected` tests.
davidlehn 48384cb
Add spec text for detecting errors when changing protected term defin…
gkellogg 7ccd943
typo
pchampin 8b0e774
Add _from term_ to context processing from Compaction algorithm when …
gkellogg 55c5440
Add missing pr02 for compact tests.
gkellogg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "@context": [{ | ||
| "@vocab": "http://example.com/", | ||
| "@version": 1.1, | ||
| "protected": {"@protected": true} | ||
| }, null] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [{ | ||
| "http://example/a": [{"@id": "http://example.org/foo"}] | ||
| }] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "@context": [{ | ||
| "@vocab": "http://example.com/", | ||
| "@version": 1.1, | ||
| "protected": {"@protected": true} | ||
| }, { | ||
| "protected": "http://example.com/protected" | ||
| }] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [{ | ||
| "http://example/a": [{"@id": "http://example.org/foo"}] | ||
| }] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "@context": { | ||
| "@version": 1.1, | ||
| "@vocab": "http://example.com/", | ||
| "protected": {"@protected": true}, | ||
| "Type": {"@context": {"protected": {"@type": "@id"},}} | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| [{ | ||
| "http://example.com/protected": [{"@value": "p === http://example.com/protected"}], | ||
| "http://example.com/unprotected": [{ | ||
| "@type": "http://example.com/Type", | ||
| "http://example.com/protected": [{"@value": "p === http://example.com/protected"}] | ||
| }] | ||
| }] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "@context": { | ||
| "@version": 1.1, | ||
| "@vocab": "http://example.com/", | ||
| "protected": {"@protected": true}, | ||
| "unprotected": {"@context": {"protected": {"@language": "en"}}} | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| [{ | ||
| "http://example.com/protected": [{"@value": "p === http://example.com/protected"}], | ||
| "http://example.com/unprotected": [{ | ||
| "http://example.com/protected": [{ | ||
| "@value": "p === http://example.com/protected", | ||
| "@language": "en" | ||
| }] | ||
| }] | ||
| }] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "@context": { | ||
| "@version": 1.1, | ||
| "@vocab": "http://example.com/", | ||
| "protected": {"@protected": true}, | ||
| "unprotected": { | ||
| "@context": {"protected": {"@language": "en"}} | ||
| } | ||
| }, | ||
| "protected": "p === http://example.com/protected", | ||
| "unprotected": { | ||
| "protected": "p === http://example.com/protected" | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one thing we might want to modify here is to allow for "redefinitions" that cause the exact same term definition to occur. There's really no reason disallow that from an authorship perspective -- and people might be surprised that they can't combine two contexts that share a common base context with protected terms. On the other hand, this would complicate implementation.
@davidlehn -- since you were in the code most recently, would this be a tough thing to support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way, I don't think that this should hold up the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could say that an attempt to redefine a term definition that is exactly equivalent to the existing definition is allowed, needing to define what we mean by equivalent, but it seems an unnecessary complication to me.