Add checks for terms including a colon #82
Conversation
…ovide for terms ending with a colon. Modify, obsolete and add tests accordingly.
| "@type": ["jld:NegativeEvaluationTest", "jld:ExpandTest"], | ||
| "name": "Term definition with @id: @type", | ||
| "purpose": "Expanding term mapping to @type uses @type syntax now illegal", | ||
| "input": "expand/e043-in.jsonld", |
There was a problem hiding this comment.
The label #te043 here doesn't match the input file name prefix e043 (same for e044) -- which seems to break the naming convention, so I suspect this is a typo. Just checking here, was this intentional or a typo?
There was a problem hiding this comment.
Tests all of an identifier such as #txxxx with corresponding files expand/xxxx-in.jsonld and expand/xxx-out.jsonld. In this case the #te043 is consistent with the file named e043-in and follows the same pattern as that for #te042.
There was a problem hiding this comment.
I think the convention has been the test ids have a t prefix, the file names don't. Is that what you meant?
There was a problem hiding this comment.
Yes, the ids all start with a "t", the filename's don't. This convention was established in the 1.0 days. I established the practice if replacing one or two leading zeros with letters to help separate out the new tests by broad feature categorization, which helps in filtering as well.
The #texxx tests typically are for errors, some of which previously came from a separate error manifest.
which do not expand in a natural way.
For w3c/json-ld-syntax#155
Preview | Diff