Skip to content

Replace @first and @last with `@once. #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 22, 2019
Merged

Conversation

gkellogg
Copy link
Member

Some pre-existing tests marked json-ld-1.0 and new tests added. The ordered option is added to these tests to guarantee predictable results.

Fixes #43.

…ked `json-ld-1.0` and new tests added. The `ordered` option is added to these tests to guarantee predictable results.

Fixes #43.
Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few minor typo fixes, otherwise LGTM. We haven't run the tests or updated our implementation yet... can't get to that this week.

dlongley and others added 5 commits April 22, 2019 08:34
Co-Authored-By: gkellogg <[email protected]>
Co-Authored-By: gkellogg <[email protected]>
Co-Authored-By: gkellogg <[email protected]>
Co-Authored-By: gkellogg <[email protected]>
Co-Authored-By: gkellogg <[email protected]>
@gkellogg gkellogg merged commit 74820b4 into master Apr 22, 2019
@gkellogg gkellogg deleted the issue-43-embed-once branch April 22, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore supporting "@embed": "@first"
2 participants