Change from "sealed" to "protected". #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidlehn it would be useful if you used branches on w3c/json-ld-syntax rather than your own; this makes it easier for others to contribute changes to the PR. |
|
Pull in 2f733d7, which should fix build issues. |
|
@gkellogg I don't have the w3c repo permissions to do that. I moved the related API repo work to a digitalbazaar repo so it wasn't my personal one. I didn't do the same with this one to avoid the churn. |
|
@iherman can you give @davidlehn permissions on the various repos to be able to create branches? |
done. |
|
For #137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it's decided to change the naming from
@sealedto@protected, here's a patch.Preview | Diff