Skip to content

Encapsulate HTML processing #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2019
Merged

Encapsulate HTML processing #214

merged 1 commit into from
Aug 26, 2019

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Aug 19, 2019

Update Embedding JSON-LD in HTML Documents to reference the "HTML script extraction" feature that processors may implement. Also, removes processor levels describing this as a processor supporting "HTML script extraction".

For #213.


Preview | Diff

…ipt extraction" feature that processors may implement. Also, removes processor levels describing this as a processor supporting "HTML script extraction".

For #213.
@iherman
Copy link
Member

iherman commented Aug 23, 2019

This issue was discussed in a meeting.

  • RESOLVED: gkellogg to merge w3c/json-ld-api#135 and #214 after reviewers have approved and close the relevant issues
View the transcript ncapsulate HTML processing
Rob Sanderson: See Syntax #214
Rob Sanderson: See API w3c/json-ld-api#135
Rob Sanderson: Discussion from last week has resulted in some PRs.
Ivan Herman: Gregg not here this week.
Pierre-Antoine Champin: dlongley: PRs are moving in a direction I would agree with
Rob Sanderson: I would agree as well, pushing things into the document loader as discussed last week.
… I guess the issue to discuss is – is there anyone who is not comfortable yet otherwise we should accept those PRs.
Pierre-Antoine Champin: scribeassist: pchampin
Rob Sanderson: Any objections to the approach?
Ivan Herman: I read through the documents and we have done the work.
Pierre-Antoine Champin: dlongley: I would like to wait for other reviews before minerging (including mine)
Proposed resolution: gkellogg to merge w3c/json-ld-api#135 and #214 after reviewers have approved (Rob Sanderson)
Proposed resolution: gkellogg to merge w3c/json-ld-api#135 and #214 after reviewers have approved and close the relevant issues (Rob Sanderson)
Dave Longley: +1
Ruben Taelman: +1
Rob Sanderson: +1
Benjamin Young: +1
Pierre-Antoine Champin: +1
Ivan Herman: +1
David I. Lehn: +1
Resolution #2: gkellogg to merge w3c/json-ld-api#135 and #214 after reviewers have approved and close the relevant issues

@gkellogg gkellogg merged commit 413ebc8 into master Aug 26, 2019
@gkellogg gkellogg deleted the partition-html branch August 26, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants