Skip to content

proposed note to address #318 #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 18, 2019
Merged

proposed note to address #318 #319

merged 5 commits into from
Dec 18, 2019

Conversation

pchampin
Copy link
Contributor

@pchampin pchampin commented Dec 17, 2019 •
edited by pr-preview bot
Loading

@gkellogg
Copy link
Member

@iherman does this rise to the level of needing to add something to a changes since CR section?

@iherman
Copy link
Member

iherman commented Dec 17, 2019

@iherman does this rise to the level of needing to add something to a changes since CR section?

Yes. It is a direct response to a public issue.

@gkellogg gkellogg requested a review from iherman December 17, 2019 20:06
@gkellogg gkellogg mentioned this pull request Dec 18, 2019
Closed
@gkellogg gkellogg merged commit a857b42 into master Dec 18, 2019
@gkellogg gkellogg deleted the issue318 branch December 18, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkellogg gkellogg gkellogg approved these changes

@iherman iherman Awaiting requested review from iherman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pchampin @gkellogg @iherman