Clarify CORS behavior for report uploads #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report uploads are supposed to behave The Right Way and send CORS preflight requests. We have to set Fetch's `unsafe-request` flag to trigger the preflights, and we also need to have a reasonable `Origin`. We use the origin of the reports themselves. This means that any particular report upload can only contain reports about a single origin, so this patch also adds an extra step to the upload algorithm to sort reports by origin after endpoints have been chosen.
* master: Rename "report list" -> "report queue" (w3c#104) Clarify name of "observability" property (w3c#101) Add notes about load balancing mechanism (w3c#94) Fix typos (w3c#106) addressed comments Update "WICG" -> "W3C" Adding baseline CODE_OF_CONDUCT.md Use real User-Agent string in examples (w3c#98) Update links to JSON RFC (w3c#99) Collect current User-Agent when queueing a report (w3c#96) fixup s/report+json/reports+json/ Define the MIME type in more detail.
|
I'm going to go ahead and merge this; if there are any issues with the new text, we can address them in follow-on CLs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report uploads are supposed to behave The Right Way and send CORS preflight requests. We have to set Fetch's
unsafe-requestflag to trigger the preflights, and we also need to have a reasonableOrigin. We use the origin of the reports themselves. This means that any particular report upload can only contain reports about a single origin, so this patch also adds an extra step to the upload algorithm to sort reports by origin after endpoints have been chosen.Preview | Diff