Definitions for Values Insertion #177
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallTed
suggested changes
Jan 8, 2025
spec/index.html
Outdated
| This applies to `BIND`, variables introduced by `AS` in a `SELECT` clause, variables in a `VALUES` | ||
| clause, and variables intrucded by `AS` in `GROUP BY`. | ||
| </blockquote> | ||
| <p>Extend the "in-scope" rules to include the variables in-scope from the current row:</p> |
There was a problem hiding this comment.
Suggested change
| <p>Extend the "in-scope" rules to include the variables in-scope from the current row:</p> | |
| <p>Extend the "in-scope" rules to include the variables that are in-scope for the current row:</p> |
spec/index.html
Outdated
|
|
||
| <p class="note"> | ||
| A variable inside a project expression that is not in the variables projected | ||
| is not affected by the values insertion operation because it is renamed apart. |
There was a problem hiding this comment.
Suggested change
| is not affected by the values insertion operation because it is renamed apart. | |
| is not affected by the value insertion operation because it is renamed apart. |
Comment on lines
+10373
to
+10430
| <!-- ValuesInsertion --> | ||
| <section> | ||
| <h3>Values Insertion and `EXISTS`</h3> |
There was a problem hiding this comment.
Values Insertion reads very oddly to me. Can this be changed (throughout) to Value Insertion?
Suggested change
| <!-- ValuesInsertion --> | |
| <section> | |
| <h3>Values Insertion and `EXISTS`</h3> | |
| <!-- ValueInsertion --> | |
| <section> | |
| <h3>Value Insertion and `EXISTS`</h3> |
There was a problem hiding this comment.
It is inserting multiple values.
There was a problem hiding this comment.
Do you use an "eggs beater" or an "egg beater"?
spec/index.html
Outdated
| <div> | ||
| <b>Definition: <span id="defn_valuesinsertion" name="defn_valuesinsertion">Values Insertion</span></b> | ||
| <p> | ||
| Define the Values Insertion function `ValuesInsert(X, μ)` |
There was a problem hiding this comment.
If, as I suggested above, Values Insertion is being changed to Value Insertion, then ValuesInsert should likewise be changed to ValueInsert
Suggested change
| Define the Values Insertion function `ValuesInsert(X, μ)` | |
| Define the Value Insertion function `ValueInsert(X, μ)` |
| <pre>exists(X) = true | ||
| if eval( D(G), ValuesInsert(PrjMap(X), μ) ) | ||
| is a non-empty solution sequence. | ||
| exists(X) = false otherwise</pre> |
There was a problem hiding this comment.
Suggested change
| exists(X) = false otherwise</pre> | |
| Otherwise, exists(X) = false.</pre> |
There was a problem hiding this comment.
The style here is that for function definition, with each case being aligned. It is not running text.
3 tasks
afs
force-pushed
the
values-insertion
branch
2 times, most recently
from
0818131 to
95b4b0a
Compare
afs
force-pushed
the
values-insertion
branch
3 times, most recently
from
c00cb1b to
a0ccbd5
Compare
|
In my view "values insertion" is the correct phrase to use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A replacement for
substitute.The context is taken from SEP-0007.
Currently, all new material is in a single section.
I am submitting this PR to put the content under the WG agreement for IP and Licensing.
Preview | Diff