-
Notifications
You must be signed in to change notification settings - Fork 3
Namespace document cleanup #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Two comments:
|
| . | ||
|
|
||
| sparql:not-equals rdf:type sparql:Operator ; | ||
| sparql:not-equals rdf:type sparql:Function ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: it's a bit weird to have not-equals but greaterThan. I would normalize to camlCase or kebab-case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing greaterThan et al. makes sense - the equivalent F&O functions are spelt - style.
Where SPARQL has a keyword, e.g hasLang, str*, I think hyphen in the local name isn't so good though hasLang* could be re-cased.
This PR already has approvals so I'll do a second PR.
This comment was marked as resolved.
This comment was marked as resolved.
| rdfs:comment "This operator calculates the logical 'not' of two RDF terms" ; | ||
| rdfs:isDefinedBy <http://www.w3.org/TR/sparql12-query/> ; | ||
|
|
||
| sparql:logical-not rdf:type sparql:Functional ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this sparql:Functional instead be sparql:Function?
and This form below be This function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Functional Form" is the technical term.
It is used as a section heading in the document.
Functional Forms are not functions. They can look like them but they have different evaluation rules.
IF(condition, then, else) is not a function. It only evaluates one of the branches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sparql:logical-not isn't listed in the spec as either a function or a functional form, though. It's listed only in the operator mapping section (along with functional forms such as logical-and, logical-or, and others).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the use of fn:not within the operator dispatch table (EBV+the error handling).
It is a function, unlike &&.
Given && is logical-and and || is logical-or, expecting something for ! seems natural.
sparql:logical-andand alsosparql:operator-and. Same foror.sparql:logical-not+are functions. Make both asparql:Functionand asparql:OperatorI don't think
sparql:Operatoradds anything. It is used for operations (functions, and some functional forms) that have specific operator-style syntax. But they are functions and functional forms - syntax goes away.Proposal: also remove
sparql:Operator- this is the second commit of the PR.