Skip to content

Conversation

@afs
Copy link
Contributor

@afs afs commented Jun 4, 2025

  • Corrects mistake: tehre was sparql:logical-and and also sparql:operator-and. Same for or.
  • Add sparql:logical-not
  • Operations like + are functions. Make both a sparql:Function and a sparql:Operator

I don't think sparql:Operator adds anything. It is used for operations (functions, and some functional forms) that have specific operator-style syntax. But they are functions and functional forms - syntax goes away.

Proposal: also remove sparql:Operator - this is the second commit of the PR.

@afs afs changed the title Mamespace document cleanup Namespace document cleanup Jun 4, 2025
@afs afs requested review from Tpt, hartig, kasei and rubensworks June 4, 2025 10:32
@domel
Copy link
Contributor

domel commented Jun 4, 2025

Two comments:

  1. dc:date "2025-06-30" ; -> dc:date "2025-06-30^^xsd:date" ;
  2. in sparql:isURI -> sparql:isURI owl:equivalentClass sparql:isIRI .

.

sparql:not-equals rdf:type sparql:Operator ;
sparql:not-equals rdf:type sparql:Function ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: it's a bit weird to have not-equals but greaterThan. I would normalize to camlCase or kebab-case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing greaterThan et al. makes sense - the equivalent F&O functions are spelt - style.

Where SPARQL has a keyword, e.g hasLang, str*, I think hyphen in the local name isn't so good though hasLang* could be re-cased.

This PR already has approvals so I'll do a second PR.

@TallTed

This comment was marked as resolved.

@afs afs merged commit 0aa2b6e into main Jun 5, 2025
2 checks passed
@afs afs deleted the ns-cleanup branch June 5, 2025 07:42
rdfs:comment "This operator calculates the logical 'not' of two RDF terms" ;
rdfs:isDefinedBy <http://www.w3.org/TR/sparql12-query/> ;

sparql:logical-not rdf:type sparql:Functional ;
Copy link
Member

@TallTed TallTed Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this sparql:Functional instead be sparql:Function?
and This form below be This function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Functional Form" is the technical term.
It is used as a section heading in the document.

Functional Forms are not functions. They can look like them but they have different evaluation rules.

IF(condition, then, else) is not a function. It only evaluates one of the branches.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sparql:logical-not isn't listed in the spec as either a function or a functional form, though. It's listed only in the operator mapping section (along with functional forms such as logical-and, logical-or, and others).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the use of fn:not within the operator dispatch table (EBV+the error handling).

It is a function, unlike &&.

Given && is logical-and and || is logical-or, expecting something for ! seems natural.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants