-
Notifications
You must be signed in to change notification settings - Fork 3
Adds links to algebraic syntax symbols within the Property Paths eval section #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The trouble with this "do it later" approach is that it tends to result in a LARGE amount of polishing that is needed when a WG is under significant time pressure. The existing changes in this PR will lead to a similar level of merge conflict as may result from applying language and punctuation fixes now to the same areas. Those merge conflicts will be no more difficult to resolve with the language and punctuation fixes than they will be to resolve without them. That said, I will resist the urge to add such fixes to this PR until and unless you agree that this is a good place for them, and I will only comment on the existing changes herein. |
Co-authored-by: Ted Thibodeau Jr <[email protected]>
TallTed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, with my last tweaks above.
Co-authored-by: Ted Thibodeau Jr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly taboput presentation of definitions, trying to get rid of scroll bars.
One question about eval vs ppeval.
One note that RDF Concepts now defines "nodes".
Co-authored-by: Andy Seaborne <[email protected]>
I have applied all these changes.
I have responded to that one inline (directly as a response to the comment).
I have applied your edit suggestion for that one as well. |
This is the next step related to #228
This PR makes the following changes, all within Section 18.5 Property Path Patterns.
<var>..</var>markup within that section.eval(Path(X, PP, Y))everywhere. As it is always Path and nothing else, I decided to simplify the notation by dropping Path. Hence, now it is something likeppeval(X, PP, Y)everywhere.To make reviewing this PR easier for you, I tried to keep the rest of the text of the section (after the introductory paragraphs) as is and only add the relevant markup there. (In this sense, I would prefer edit suggestions only on the things that this PR actually changes. I noticed a bunch of language and punctuation issues in the parts that this PR touches, but I think it is more helpful to ignore them for now and come back to them in a separate PR later.)
Preview | Diff