Skip to content

Conversation

@afs
Copy link
Contributor

@afs afs commented Jan 6, 2026

This closes #337.


Preview | Diff

@afs afs force-pushed the afs/concat-args branch from 487c7ce to 7a67f7b Compare January 6, 2026 12:10
@afs afs requested review from Tpt, hartig and kasei and removed request for Tpt and hartig January 6, 2026 12:10
@TallTed
Copy link
Member

TallTed commented Jan 6, 2026

This fix looks good as far as it goes.

We might need another issue to add a CONCAT argument for a separators, that the each two arguments are separated by that separator (such as , or ;), which the user might also want terminate the output.

There is also a known desire for ORDER BY on the CONCAT argument(s), in cases such as

SELECT ?x
       ( ( CONCAT ( ?s1 ASC ", " ) ) AS ?s1concat )
       ( ( CONCAT ( ?s2 DESC ";" ) ) AS ?s2concat )
WHERE  { }

@afs
Copy link
Contributor Author

afs commented Jan 6, 2026

@TallTed -- I think you are mixing this up with GROUP_CONCAT.

@TallTed
Copy link
Member

TallTed commented Jan 6, 2026

I think you are mixing this [CONCAT] up with GROUP_CONCAT.

Fooey. Correct. Too many threads tangling in my head!

Copy link
Contributor

@hartig hartig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (with a preference for adding @TallTed's suggestion to this PR).

Co-authored-by: Ted Thibodeau Jr <[email protected]>
@afs afs merged commit 06d2978 into main Jan 8, 2026
2 checks passed
@afs afs deleted the afs/concat-args branch January 8, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Argument handling of CONCAT is defined inconsistently.

7 participants