Fixes inconsistencies in definition of evaluation of property path with sequence #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty path with sequence
Tpt
approved these changes
Jan 18, 2026
rubensworks
approved these changes
Jan 19, 2026
kasei
reviewed
Jan 19, 2026
kasei
approved these changes
Jan 19, 2026
Co-authored-by: Gregory Todd Williams <[email protected]>
afs
reviewed
Jan 22, 2026
| <p>where |PV| = { |v| ∈ {|X|,|Y|} | |v| is a variable}.</p> | ||
| <div class="issue" data-number="266"><a href="#defn_algJoin" class="algFct">Join</a> produces a multiset of solution mappings but <a href="#defn_algProject" class="algFct">Project</a> expects a sequence as its first argument. Moreover, <a href="#defn_algProject" class="algFct">Project</a> produces a sequence but ppeval(..) should be a multiset.</div> | ||
| <pre class="nohighlight">ppeval(<var>X</var>, <a href="#defn_ppeSeq" class="ppeOp">Seq</a>(<var>ppe<sub>1</sub></var>, <var>ppe<sub>2</sub></var>), <var>Y</var>) = <a href="#defn_algToMultiSet" class="algFct">ToMultiSet</a>( <a href="#defn_algProject" class="algFct">Project</a>(<a href="#defn_algToList" class="algFct">ToList</a>(<var>A</var>), <var>PV</var>) )</pre> | ||
| <p>where |A| = |
Contributor
There was a problem hiding this comment.
Miinor/preference: I find it easier if things are defined before they are used -- i.e. A = before ToList(A).
Contributor
Author
There was a problem hiding this comment.
Honestly, I don't find that easier. At least not in the way it looks like at the moment (i.e., before this PR):
There I am just wondering: what is this A about, why isn't this definition just defining the ppeval as all other definitions in this section do?
Co-authored-by: Andy Seaborne <[email protected]>
afs
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #266 by implementing exactly the change described in #266. Additionally, this PR changes the order of things in the definition box.
Preview | Diff